fix some small bugs for gamemode fw #897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
JMM889901
reviewed
Nov 4, 2024
| @@ -124,6 +124,10 @@ void function GamemodeFW_Init() | |||
| // _battery_port.gnut needs this | |||
| RegisterSignal( "BatteryActivate" ) | |||
|
|
|||
| // mp_thaw's intro spawnpoint have some problem, player can be stucked on the sky, so override it | |||
| if ( GetMapName() == "mp_thaw" ) | |||
| SetSpawnpointGamemodeOverride( TEAM_DEATHMATCH ) | |||
There was a problem hiding this comment.
Does FW have custom spawn logic usually? I'm not sure how i feel about getting rid of that spawn logic for a given map, if its just the intro sequence could we set it back after?
Zanieon
approved these changes
Nov 25, 2024
Zanieon
removed
the
needs code review
Zanieon
added
READY TO MERGE
|
Tested and so far no compile errors or problems ingame. |
|
Uh, what bugs exactly does this fix? Would be nice to have unrelated changes separated out ^^" |
|
|
Whoops, never saw your reply.... 🫠 Would it be possible to split up the changes? ^^" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #868 for more infomation
i deleted my repo cuz i though its all finished, really sorry for that
my english doesnt very well, lmk if u need more infomation